Struts 2.4

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

Struts 2.4

Lukasz Lenart
Hi,

I'm going to release a new version of Struts 2.3.x but because we are
not able to support 2.3.x on Java 6, I will switch to Java 7 and brand
it Struts 2.4


Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Yasser Zamani-2


On 11/29/2017 11:26 AM, Lukasz Lenart wrote:
> I'm going to release a new version of Struts 2.3.x but because we are
> not able to support 2.3.x on Java 6, I will switch to Java 7 and brand
> it Struts 2.4

Now that root cause of JDK6 compile fails found [1], I think we can
delete 2.4 branch entirely and continue back with 2.3.x :)

Regards.

[1]
https://github.com/apache/struts/commit/afc8f20440f80564d48cb1cc9904c76e02e84aac

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Lukasz Lenart
Not really :(

https://builds.apache.org/view/S-Z/view/Struts/job/Struts-2-3-JDK6/2/console

2018-04-24 16:03 GMT+02:00 Yasser Zamani <[hidden email]>:

>
>
> On 11/29/2017 11:26 AM, Lukasz Lenart wrote:
>> I'm going to release a new version of Struts 2.3.x but because we are
>> not able to support 2.3.x on Java 6, I will switch to Java 7 and brand
>> it Struts 2.4
>
> Now that root cause of JDK6 compile fails found [1], I think we can
> delete 2.4 branch entirely and continue back with 2.3.x :)
>
> Regards.
>
> [1]
> https://github.com/apache/struts/commit/afc8f20440f80564d48cb1cc9904c76e02e84aac

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Yasser Zamani-2


On 4/25/2018 10:08 AM, Lukasz Lenart wrote:
> Not really :(
>
> https://builds.apache.org/view/S-Z/view/Struts/job/Struts-2-3-JDK6/2/console

I found that 2.4 has following diff:

pom.xml
<excludes>
<exclude>**/TestBean.java</exclude>
+<exclude>**/Struts2PortletTest.java</exclude>
+<exclude>**/ChartResultTest.java</exclude>
</excludes>

and I see in my local, 2.3.x also starts working with this change, but
I'm going to see if I can keep them with a successful build at local
which might fix also Jenkins fail :)

Regards.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Lukasz Lenart
2018-04-25 10:06 GMT+02:00 Yasser Zamani <[hidden email]>:
> I found that 2.4 has following diff:
>
> pom.xml
> <excludes>
> <exclude>**/TestBean.java</exclude>
> +<exclude>**/Struts2PortletTest.java</exclude>
> +<exclude>**/ChartResultTest.java</exclude>
> </excludes>

Ach... right :)


Regatds
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Yasser Zamani-2


On 4/25/2018 12:38 PM, Lukasz Lenart wrote:

> 2018-04-25 10:06 GMT+02:00 Yasser Zamani <[hidden email]>:
>> I found that 2.4 has following diff:
>>
>> pom.xml
>> <excludes>
>> <exclude>**/TestBean.java</exclude>
>> +<exclude>**/Struts2PortletTest.java</exclude>
>> +<exclude>**/ChartResultTest.java</exclude>
>> </excludes>
>
> Ach... right :)
>

I see even STRUTS_2_3_24 (5/3/2015) fails on Struts2PortletTest.java
(with both JDK6 & 7 and last compatible mvn with it)!

Caused by: org.apache.jasper.JasperException:
/WEB-INF/view/index.jsp(1,42) PWC6117: File "/struts-tags" not found
        at
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:73)
        at
org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:359)
        at
org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:153)
        at
org.apache.jasper.compiler.TagLibraryInfoImpl.<init>(TagLibraryInfoImpl.java:234)


I couldn't find last successful build of 2.3.x in Jenkins (to check if
this test is disabled there via command line options or Jenkins config).
Do you have any full log please? Or can you recall how we was able to
release 2.3.x these years with this failed test, please?

Thanks in advance!

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Lukasz Lenart
2018-04-26 8:44 GMT+02:00 Yasser Zamani <[hidden email]>:

> I see even STRUTS_2_3_24 (5/3/2015) fails on Struts2PortletTest.java
> (with both JDK6 & 7 and last compatible mvn with it)!
>
> Caused by: org.apache.jasper.JasperException:
> /WEB-INF/view/index.jsp(1,42) PWC6117: File "/struts-tags" not found
>         at
> org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:73)
>         at
> org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:359)
>         at
> org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:153)
>         at
> org.apache.jasper.compiler.TagLibraryInfoImpl.<init>(TagLibraryInfoImpl.java:234)
>
>
> I couldn't find last successful build of 2.3.x in Jenkins (to check if
> this test is disabled there via command line options or Jenkins config).
> Do you have any full log please? Or can you recall how we was able to
> release 2.3.x these years with this failed test, please?

It used to passing, I assume it has something to do with using newest
Servlet API in tests but didn't find any solution.


Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Yasser Zamani-2


On 4/26/2018 11:17 AM, Lukasz Lenart wrote:

> 2018-04-26 8:44 GMT+02:00 Yasser Zamani <[hidden email]>:
>> I see even STRUTS_2_3_24 (5/3/2015) fails on Struts2PortletTest.java
>> (with both JDK6 & 7 and last compatible mvn with it)!
>>
>> Caused by: org.apache.jasper.JasperException:
>> /WEB-INF/view/index.jsp(1,42) PWC6117: File "/struts-tags" not found
>>         at
>> org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:73)
>>         at
>> org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:359)
>>         at
>> org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:153)
>>         at
>> org.apache.jasper.compiler.TagLibraryInfoImpl.<init>(TagLibraryInfoImpl.java:234)
>>
>>
>> I couldn't find last successful build of 2.3.x in Jenkins (to check if
>> this test is disabled there via command line options or Jenkins config).
>> Do you have any full log please? Or can you recall how we was able to
>> release 2.3.x these years with this failed test, please?
>
> It used to passing, I assume it has something to do with using newest
> Servlet API in tests but didn't find any solution.
>

So now I'm confused how this is possible. As I mentioned I checked out
STRUTS_2_3_24 which has been released about 3 years ago which means we
was able to have a successful build with JDK6 from it. But now it fails
in exactly same environment (same jdk, same source codes)! I see, now,
it uses maven-jetty-pluto-embeded for servlet in tests, i.e. like 3
years ago, then it shouldn't make sense changing servlet api.

So as everything is same I expect there may something in command line
options or Jenkins config which made us able to build 2.3.24. wdyt?

Regards.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Lukasz Lenart
2018-04-26 9:52 GMT+02:00 Yasser Zamani <[hidden email]>:
> So now I'm confused how this is possible. As I mentioned I checked out
> STRUTS_2_3_24 which has been released about 3 years ago which means we
> was able to have a successful build with JDK6 from it. But now it fails
> in exactly same environment (same jdk, same source codes)! I see, now,
> it uses maven-jetty-pluto-embeded for servlet in tests, i.e. like 3
> years ago, then it shouldn't make sense changing servlet api.
>
> So as everything is same I expect there may something in command line
> options or Jenkins config which made us able to build 2.3.24. wdyt?

It works for me, I meant the portlet test passes when using 2.3.24 tag
(JFreeChart is failing but I assume it has something to do with
libjpg)


Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Yasser Zamani-2


On 4/26/2018 12:30 PM, Lukasz Lenart wrote:

> 2018-04-26 9:52 GMT+02:00 Yasser Zamani <[hidden email]>:
>> So now I'm confused how this is possible. As I mentioned I checked out
>> STRUTS_2_3_24 which has been released about 3 years ago which means we
>> was able to have a successful build with JDK6 from it. But now it fails
>> in exactly same environment (same jdk, same source codes)! I see, now,
>> it uses maven-jetty-pluto-embeded for servlet in tests, i.e. like 3
>> years ago, then it shouldn't make sense changing servlet api.
>>
>> So as everything is same I expect there may something in command line
>> options or Jenkins config which made us able to build 2.3.24. wdyt?
>
> It works for me, I meant the portlet test passes when using 2.3.24 tag
> (JFreeChart is failing but I assume it has something to do with
> libjpg)

Ach... you're right! I see currently Jenkins also is able to pass it
with latest 2.3.x [1]. So I think fixing current Jenkins JFreeChart
failing means we can continue back with 2.3.x and JDK6 :)

Regards.

[1]
https://builds.apache.org/view/S-Z/view/Struts/job/Struts-2-3-JDK6/2/consoleFull

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.struts2.portlet.test.Struts2PortletTest
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for
further details.
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.532 sec


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Yasser Zamani-2


On 4/26/2018 12:45 PM, Yasser Zamani wrote:

>
>
> On 4/26/2018 12:30 PM, Lukasz Lenart wrote:
>> 2018-04-26 9:52 GMT+02:00 Yasser Zamani <[hidden email]>:
>>> So now I'm confused how this is possible. As I mentioned I checked out
>>> STRUTS_2_3_24 which has been released about 3 years ago which means we
>>> was able to have a successful build with JDK6 from it. But now it fails
>>> in exactly same environment (same jdk, same source codes)! I see, now,
>>> it uses maven-jetty-pluto-embeded for servlet in tests, i.e. like 3
>>> years ago, then it shouldn't make sense changing servlet api.
>>>
>>> So as everything is same I expect there may something in command line
>>> options or Jenkins config which made us able to build 2.3.24. wdyt?
>>
>> It works for me, I meant the portlet test passes when using 2.3.24 tag
>> (JFreeChart is failing but I assume it has something to do with
>> libjpg)
>
> Ach... you're right! I see currently Jenkins also is able to pass it
> with latest 2.3.x [1]. So I think fixing current Jenkins JFreeChart
> failing means we can continue back with 2.3.x and JDK6 :)
>

According to [1] then [2], it seems JFreeChartTest fails on OpenJDK
because "OpenJDK does not have a native JPEG encoder". However, I'm not
sure. Could you please test if same fail occurs with another JDK? I
wasn't able to do myself as I don't have access to ASF Jenkins Jobs.

Thanks in advance!

[1]
https://builds.apache.org/view/S-Z/view/Struts/job/Struts-2-3-JDK6/4/console
[2] https://stackoverflow.com/a/3432532/1362623

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Lukasz Lenart
2018-04-26 20:01 GMT+02:00 Yasser Zamani <[hidden email]>:
> According to [1] then [2], it seems JFreeChartTest fails on OpenJDK
> because "OpenJDK does not have a native JPEG encoder". However, I'm not
> sure. Could you please test if same fail occurs with another JDK? I
> wasn't able to do myself as I don't have access to ASF Jenkins Jobs.

Looks like you are right, switching to non-OpenJDK resolved the
problem. So we can release a new 2.3.x version :)

And if you need access to Jenkins, just register a ticket for INFRA.


Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Yasser Zamani-2


On 4/27/2018 10:12 AM, Lukasz Lenart wrote:
> Looks like you are right, switching to non-OpenJDK resolved the
> problem. So we can release a new 2.3.x version :)
>

Great! I think we also can delete 2.4 branch as now we're able to build
2.3.x with java 6 :)

> And if you need access to Jenkins, just register a ticket for INFRA.

Thanks! I though only PMC have such access.

Regards.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Lukasz Lenart
Great, I will prepare a new release :)

2018-04-27 13:43 GMT+02:00 Yasser Zamani <[hidden email]>:

>
>
> On 4/27/2018 10:12 AM, Lukasz Lenart wrote:
>> Looks like you are right, switching to non-OpenJDK resolved the
>> problem. So we can release a new 2.3.x version :)
>>
>
> Great! I think we also can delete 2.4 branch as now we're able to build
> 2.3.x with java 6 :)
>
>> And if you need access to Jenkins, just register a ticket for INFRA.
>
> Thanks! I though only PMC have such access.
>
> Regards.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Lukasz Lenart
I'm working on a new release of Struts 2.3.x but it will be the last
release from this branch, it's very hard to keep support especially
using Java 6 and old dependencies.

2018-05-02 8:15 GMT+02:00 Lukasz Lenart <[hidden email]>:

> Great, I will prepare a new release :)
>
> 2018-04-27 13:43 GMT+02:00 Yasser Zamani <[hidden email]>:
>>
>>
>> On 4/27/2018 10:12 AM, Lukasz Lenart wrote:
>>> Looks like you are right, switching to non-OpenJDK resolved the
>>> problem. So we can release a new 2.3.x version :)
>>>
>>
>> Great! I think we also can delete 2.4 branch as now we're able to build
>> 2.3.x with java 6 :)
>>
>>> And if you need access to Jenkins, just register a ticket for INFRA.
>>
>> Thanks! I though only PMC have such access.
>>
>> Regards.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Yasser Zamani-2


On 5/8/2018 11:16 AM, Lukasz Lenart wrote:
> I'm working on a new release of Struts 2.3.x but it will be the last
> release from this branch, it's very hard to keep support especially
> using Java 6 and old dependencies.

I thought I should say that I had found that recent difficulties with
building support-2-3 branch was started after "WW-4844 Upgrades to
struts-master 11" [1] which increases some fundamental common
dependencies (e.g. maven compiler plugin) versions. I mean if it's
possible to not increase struts-master version (and maybe other
dependencies) then maybe it's possible to keep this support if it's
required.

May I ask what happens with 2-4 branch? I ask because there are commits
on it which I would like to know if they need reviews or migration to 2-3.

Regards.

[1]
https://github.com/apache/struts/commit/f11ac901d3074111db05239b15dac0dd44ede5bb

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Struts 2.4

Lukasz Lenart
I was referring to Jackson library, which uses Java 7 now and I'm not
able to port this fix to Struts 2.3.x
https://cwiki.apache.org/confluence/display/WW/S2-054

2018-05-08 9:08 GMT+02:00 Yasser Zamani <[hidden email]>:

>
>
> On 5/8/2018 11:16 AM, Lukasz Lenart wrote:
>> I'm working on a new release of Struts 2.3.x but it will be the last
>> release from this branch, it's very hard to keep support especially
>> using Java 6 and old dependencies.
>
> I thought I should say that I had found that recent difficulties with
> building support-2-3 branch was started after "WW-4844 Upgrades to
> struts-master 11" [1] which increases some fundamental common
> dependencies (e.g. maven compiler plugin) versions. I mean if it's
> possible to not increase struts-master version (and maybe other
> dependencies) then maybe it's possible to keep this support if it's
> required.
>
> May I ask what happens with 2-4 branch? I ask because there are commits
> on it which I would like to know if they need reviews or migration to 2-3.
>
> Regards.
>
> [1]
> https://github.com/apache/struts/commit/f11ac901d3074111db05239b15dac0dd44ede5bb

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]