[GitHub] struts pull request #158: WW-4835: Configurable handlers

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #158: WW-4835: Configurable handlers

cnenning
GitHub user lukaszlenart opened a pull request:

    https://github.com/apache/struts/pull/158

    WW-4835: Configurable handlers

    This PR changes API a bit to allow pass current `ActionInvocation` to the REST content type handlers to allow implement different behaviour based on a current action.
   
    [WW-4835](https://issues.apache.org/jira/browse/WW-4835)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukaszlenart/struts configurable-handlers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #158
   
----
commit 2f690cfe6260ccdf3aa617baf65a4b836c49cf65
Author: Lukasz Lenart <[hidden email]>
Date:   2017-08-02T12:56:09Z

    Adds new methods and marks current as deprecated

commit 3bd072ca053aed787f3a16865266d8832fcd18b0
Author: Lukasz Lenart <[hidden email]>
Date:   2017-08-02T12:58:15Z

    Adds an abstract layer to allow easily handle API change

commit a64da53d5770c5404ee5eb390b826f5733171f5f
Author: Lukasz Lenart <[hidden email]>
Date:   2017-08-02T12:59:54Z

    Updates flow to handle new API

commit ee5575d0c6b24b7109b6977542bfcc0fac8f85d3
Author: Lukasz Lenart <[hidden email]>
Date:   2017-08-02T13:00:01Z

    Updates tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [GitHub] struts pull request #158: WW-4835: Configurable handlers

Lukasz Lenart
Hi,

Can you take a look on this?


Thanks in advance
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

2017-08-02 15:02 GMT+02:00 lukaszlenart <[hidden email]>:

> GitHub user lukaszlenart opened a pull request:
>
>     https://github.com/apache/struts/pull/158
>
>     WW-4835: Configurable handlers
>
>     This PR changes API a bit to allow pass current `ActionInvocation` to the REST content type handlers to allow implement different behaviour based on a current action.
>
>     [WW-4835](https://issues.apache.org/jira/browse/WW-4835)
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/lukaszlenart/struts configurable-handlers
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/struts/pull/158.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>     This closes #158
>
> ----
> commit 2f690cfe6260ccdf3aa617baf65a4b836c49cf65
> Author: Lukasz Lenart <[hidden email]>
> Date:   2017-08-02T12:56:09Z
>
>     Adds new methods and marks current as deprecated
>
> commit 3bd072ca053aed787f3a16865266d8832fcd18b0
> Author: Lukasz Lenart <[hidden email]>
> Date:   2017-08-02T12:58:15Z
>
>     Adds an abstract layer to allow easily handle API change
>
> commit a64da53d5770c5404ee5eb390b826f5733171f5f
> Author: Lukasz Lenart <[hidden email]>
> Date:   2017-08-02T12:59:54Z
>
>     Updates flow to handle new API
>
> commit ee5575d0c6b24b7109b6977542bfcc0fac8f85d3
> Author: Lukasz Lenart <[hidden email]>
> Date:   2017-08-02T13:00:01Z
>
>     Updates tests
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at [hidden email] or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #158: WW-4835: Configurable handlers

cnenning
In reply to this post by cnenning
Github user cnenning commented on the issue:

    https://github.com/apache/struts/pull/158
 
    Using `AbstractContentTypeHandler` to implement deprecated methods to log on WARN seems like a good idea.
   
    I don't see where new parameter `ActionInvocation` is actually used. Is that yet to come?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #158: WW-4835: Configurable handlers

cnenning
In reply to this post by cnenning
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/158
 
    > I don't see where new parameter ActionInvocation is actually used. Is that yet to come?
   
    Not yet :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #158: WW-4835: Configurable handlers

cnenning
In reply to this post by cnenning
Github user cnenning commented on the issue:

    https://github.com/apache/struts/pull/158
 
    Do you want to further develop this PR or merge it first?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #158: WW-4835: Configurable handlers

cnenning
In reply to this post by cnenning
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/158
 
    Merge it first as I think those changes are less intrusive as the whole idea in my head ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #158: WW-4835: Configurable handlers

cnenning
In reply to this post by cnenning
Github user cnenning commented on the issue:

    https://github.com/apache/struts/pull/158
 
    and what is your idea?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #158: WW-4835: Configurable handlers

cnenning
In reply to this post by cnenning
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/158
 
    With the `ActionInvocation` in place I can access an action which means the action can provide additional informations how to serialise/deserialize object/string via dedicated interfaces, e.g.
   
    ```java
    public interface DateFormatHandler {
      Date toDate(String dateStr);
      String fromDate(Date date);
    }
    ```
   
    and when action will implement such interface, a handler can pass formatting a date to the action instead of doing this by itself. And many more :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #158: WW-4835: Configurable handlers

cnenning
In reply to this post by cnenning
Github user cnenning commented on the issue:

    https://github.com/apache/struts/pull/158
 
    sounds great 👍


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #158: WW-4835: Configurable handlers

cnenning
In reply to this post by cnenning
Github user asfgit closed the pull request at:

    https://github.com/apache/struts/pull/158


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...