Quantcast

[GitHub] struts pull request #137: WW-4762: Default provider

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #137: WW-4762: Default provider

lukaszlenart-2
GitHub user lukaszlenart opened a pull request:

    https://github.com/apache/struts/pull/137

    WW-4762: Default provider

    Implements a default text provider which only operates on defined default bundles and those provided via `struts.custom.i18n.resources`
   
    Implements [WW-4762](https://issues.apache.org/jira/browse/WW-4762)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukaszlenart/struts default-provider

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #137
   
----
commit 45d1a491311a82f6b2404d839e7e18269a26192f
Author: Lukasz Lenart <[hidden email]>
Date:   2017-04-26T09:55:49Z

    WW-4762 Drops unused code

commit 3ffc9b8450845d7a90a623607e3b4bb05888e2f9
Author: Lukasz Lenart <[hidden email]>
Date:   2017-04-26T09:56:09Z

    WW-4762 Drops unused imports

commit 8bf77a1d19d31dbc8574dcbf958c3da2a4724c84
Author: Lukasz Lenart <[hidden email]>
Date:   2017-04-26T09:56:48Z

    WW-4762 Uses Struts prefix for the main implementation

commit 2e23d7a07ea4313136dc38b8de2451b04c882064
Author: Lukasz Lenart <[hidden email]>
Date:   2017-04-26T10:24:57Z

    WW-4762 Extracts base abstract class

commit bb19a6209886795b76385e48fd86424c144ee029
Author: Lukasz Lenart <[hidden email]>
Date:   2017-04-26T18:28:11Z

    WW-4762 Introduces default provider which only uses default bundles

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #137: WW-4762: Default provider

lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/137
 
    This is ready to test, to test the new bean you must specify the following constant in `struts.xml`
   
    ```xml
    <constant name="struts.localizedTextProvider" value="default-only" />
    ```
   
    now you can play with `struts.custom.i18n.resources` to define additional resource bundles.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #137: WW-4762: Default provider

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/137
 
    Any objections to merge this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #137: WW-4762: Default provider

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user gregh3269 commented on the issue:

    https://github.com/apache/struts/pull/137
 
    I can re-test it when merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #137: WW-4762: Default provider

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user asfgit closed the pull request at:

    https://github.com/apache/struts/pull/137


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #137: WW-4762: Default provider

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/137
 
    Please see docs, I have renamed the constant and the class
    https://cwiki.apache.org/confluence/display/WW/Localization#Localization-Usingonlyglobalbundles


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...