Quantcast

[GitHub] struts pull request #136: WW-4793 only add JBossFileManager when supported

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #136: WW-4793 only add JBossFileManager when supported

lukaszlenart-2
GitHub user sdutry opened a pull request:

    https://github.com/apache/struts/pull/136

    WW-4793 only add JBossFileManager when supported

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sdutry/struts WW-4793

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #136
   
----
commit f7beeacf400ec6bdb27a7d67deb3b55dcc0f5dac
Author: Stefaan Dutry <[hidden email]>
Date:   2017-05-01T05:54:19Z

    added utility innerclass for checking support

commit 4be974a482a2894b677ee4d2292ec778dfcd429e
Author: Stefaan Dutry <[hidden email]>
Date:   2017-05-01T06:00:54Z

    only add JBossFileManager when it's supported

commit b140218cf2c7c634a6c42cd859d6d3b81cb5c290
Author: Stefaan Dutry <[hidden email]>
Date:   2017-05-01T06:06:11Z

    removed redundant logger declaration

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #136: WW-4793 only add JBossFileManager when supported

lukaszlenart-2
Github user aleksandr-m commented on a diff in the pull request:

    https://github.com/apache/struts/pull/136#discussion_r114149826
 
    --- Diff: core/src/main/java/org/apache/struts2/util/fs/JBossFileManager.java ---
    @@ -210,4 +187,33 @@ private void addIfAbsent(List<URL> urls, URL fileUrl) {
             }
         }
     
    +    public static class JBossFileManagerSupportUtil {
    --- End diff --
   
    Why inner class? Why not just static methods in `JBossFileManager`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #136: WW-4793 only add JBossFileManager when supported

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user sdutry commented on a diff in the pull request:

    https://github.com/apache/struts/pull/136#discussion_r114154579
 
    --- Diff: core/src/main/java/org/apache/struts2/util/fs/JBossFileManager.java ---
    @@ -210,4 +187,33 @@ private void addIfAbsent(List<URL> urls, URL fileUrl) {
             }
         }
     
    +    public static class JBossFileManagerSupportUtil {
    --- End diff --
   
    @aleksandr-m
    Good point, let me change that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #136: WW-4793 only add JBossFileManager when supported

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user sdutry commented on a diff in the pull request:

    https://github.com/apache/struts/pull/136#discussion_r114157280
 
    --- Diff: core/src/main/java/org/apache/struts2/util/fs/JBossFileManager.java ---
    @@ -210,4 +187,33 @@ private void addIfAbsent(List<URL> urls, URL fileUrl) {
             }
         }
     
    +    public static class JBossFileManagerSupportUtil {
    --- End diff --
   
    @aleksandr-m
    Changed to static methods.
    (don't know why i didn't just do that from the start)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #136: WW-4793 only add JBossFileManager when supported

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user sdutry closed the pull request at:

    https://github.com/apache/struts/pull/136


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #136: WW-4793 only add JBossFileManager when supported

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user sdutry commented on the issue:

    https://github.com/apache/struts/pull/136
 
    Given the input on the issue, this pull request should not be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...