Quantcast

[GitHub] struts pull request #130: WW-3952: Credit card validator

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #130: WW-3952: Credit card validator

lukaszlenart-2
GitHub user lukaszlenart opened a pull request:

    https://github.com/apache/struts/pull/130

    WW-3952: Credit card validator

    Implements a credit card validator
    [WW-3952](https://issues.apache.org/jira/browse/WW-3952)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukaszlenart/struts credit-card-validations

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #130
   
----
commit 01d710bdf3dace8cf964bcd32d0afe14cf251dc2
Author: Lukasz Lenart <[hidden email]>
Date:   2017-04-19T16:05:53Z

    WW-3952 Adds implementation of credit card validator

commit fc497360bee7084293749f712dec233eb219bbf4
Author: Lukasz Lenart <[hidden email]>
Date:   2017-04-19T16:06:17Z

    WW-3952 Adds test to check implementation

commit 743d27f841ce990ed3153f569f890179bdbb6a37
Author: Lukasz Lenart <[hidden email]>
Date:   2017-04-19T16:06:31Z

    WW-3952 Introduces annotation

commit 0813eaa0c8f446404243fba87cde51a619643cb9
Author: Lukasz Lenart <[hidden email]>
Date:   2017-04-19T16:07:16Z

    WW-3952 Extends existing logic to handle credit card validation

commit eb4fcb4afc79dac03f6ed0780211f98e72a09851
Author: Lukasz Lenart <[hidden email]>
Date:   2017-04-19T16:07:38Z

    WW-3952 Updates test to include credit card validation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #130: WW-3952: Credit card validator

lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/130
 
    This is ready for review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #130: WW-3952: Credit card validator

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user cnenning commented on the issue:

    https://github.com/apache/struts/pull/130
 
    I hope the regex is stable 😉


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #130: WW-3952: Credit card validator

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/130
 
    > I hope the regex is stable
   
    What do you mean by that? I have used this http://www.regular-expressions.info/creditcard.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #130: WW-3952: Credit card validator

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user cnenning commented on the issue:

    https://github.com/apache/struts/pull/130
 
    How often do credit card companies change their number-patterns in a way that the regex needs to be updated? 'guess it is rare enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #130: WW-3952: Credit card validator

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/130
 
    Good question... I have used those random card numbers in tests and looks ok (but we will see) https://www.paypalobjects.com/en_US/vhelp/paypalmanager_help/credit_card_numbers.htm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #130: WW-3952: Credit card validator

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user cnenning commented on the issue:

    https://github.com/apache/struts/pull/130
 
    If patterns change users have another reason to upgrade to latest struts 😆


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #130: WW-3952: Credit card validator

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user gregh3269 commented on the issue:

    https://github.com/apache/struts/pull/130
 
    Last time I did some credit card validation, I needed to use a java script version as the payment process obscured the field names by not having the "name" attribute (so it was not obvious when these were sent over https) and I was unable to do server side validation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #130: WW-3952: Credit card validator

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user asfgit closed the pull request at:

    https://github.com/apache/struts/pull/130


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...