Quantcast

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

classic Classic list List threaded Threaded
34 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

lukaszlenart-2
GitHub user yasserzamani opened a pull request:

    https://github.com/apache/struts/pull/118

    [WW-4105] OgnlUtil improved in order to only setting properties defined

    With these changes, [OgnlUtil](https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java) can set only properties defined in the given "editable" class (or interface) which can be used e.g. in chaining interceptor to skip proxy properties of proxied chained actions, that avoid breaking upper level technologies like Spring Proxying.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yasserzamani/struts WW-4105

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #118
   
----
commit 6e7a14784c906f2cb6c638bef25e610459aa8f6f
Author: Yasser Zamani <[hidden email]>
Date:   2017-02-12T11:11:21Z

    [WW-4105] OgnlUtil improved in order to only setting properties defined
    in the given "editable" class (or interface)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

lukaszlenart-2
Github user lukaszlenart commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r100772955
 
    --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java ---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, CompoundRoot root) {
             Map<String, Object> ctxMap = invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), ctxMap, prepareExcludes(), includes);
    +                String actionConfigClassName = invocation.getProxy().getConfig().getClassName();
    +                Object action = invocation.getAction();
    +                if (action.getClass().getName().equals(actionConfigClassName))
    +                    reflectionProvider.copy(object, action, ctxMap, prepareExcludes(), includes, null);
    +                else { //only setting properties defined in the given config class e.g. to skip proxy properties (WW-4105)
    +                    Class <?> editable;
    +                    try {
    +                        editable =  Class.forName(actionConfigClassName);
    +                    } catch (ClassNotFoundException e) {
    +                        LOG.warn("An unexpected state. This may be due to a bug. Please report this: ClassNotFoundException" + actionConfigClassName);
    --- End diff --
   
    What about logging exception here as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r100774158
 
    --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java ---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, CompoundRoot root) {
             Map<String, Object> ctxMap = invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), ctxMap, prepareExcludes(), includes);
    +                String actionConfigClassName = invocation.getProxy().getConfig().getClassName();
    +                Object action = invocation.getAction();
    +                if (action.getClass().getName().equals(actionConfigClassName))
    +                    reflectionProvider.copy(object, action, ctxMap, prepareExcludes(), includes, null);
    +                else { //only setting properties defined in the given config class e.g. to skip proxy properties (WW-4105)
    +                    Class <?> editable;
    +                    try {
    +                        editable =  Class.forName(actionConfigClassName);
    +                    } catch (ClassNotFoundException e) {
    +                        LOG.warn("An unexpected state. This may be due to a bug. Please report this: ClassNotFoundException" + actionConfigClassName);
    --- End diff --
   
    It's better, thank you! done and committed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r100774641
 
    --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java ---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, CompoundRoot root) {
             Map<String, Object> ctxMap = invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), ctxMap, prepareExcludes(), includes);
    +                String actionConfigClassName = invocation.getProxy().getConfig().getClassName();
    +                Object action = invocation.getAction();
    +                if (action.getClass().getName().equals(actionConfigClassName))
    +                    reflectionProvider.copy(object, action, ctxMap, prepareExcludes(), includes, null);
    +                else { //only setting properties defined in the given config class e.g. to skip proxy properties (WW-4105)
    +                    Class <?> editable;
    +                    try {
    +                        editable =  Class.forName(actionConfigClassName);
    +                    } catch (ClassNotFoundException e) {
    +                        LOG.warn("An unexpected state. This may be due to a bug. Please report this: ClassNotFoundException" + actionConfigClassName);
    --- End diff --
   
    I also fixed Indentations to use 4 spaces instead of tab, both in my current PRs and my eclipse. Sorry, I'll be more careful about formatting in my next works


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r100990118
 
    --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java ---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, CompoundRoot root) {
             Map<String, Object> ctxMap = invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), ctxMap, prepareExcludes(), includes);
    +                String actionConfigClassName = invocation.getProxy().getConfig().getClassName();
    --- End diff --
   
    Please wait and do not merge until I check if getConfig and getClassName are always ready and are as expected e.g. when using convention or spring plugin!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r100990614
 
    --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java ---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, CompoundRoot root) {
             Map<String, Object> ctxMap = invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), ctxMap, prepareExcludes(), includes);
    +                String actionConfigClassName = invocation.getProxy().getConfig().getClassName();
    --- End diff --
   
    Please wait and do not merge! until I check if `getConfig` and `getClassName` are always ready and are as expected e.g. when using convention or spring plugin!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #118: [WW-4105] OgnlUtil improved in order to only setting prop...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/118
 
    @yasserzamani you should be able to mark this PR with a label `Ready for merge`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r101103182
 
    --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java ---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, CompoundRoot root) {
             Map<String, Object> ctxMap = invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), ctxMap, prepareExcludes(), includes);
    +                String actionConfigClassName = invocation.getProxy().getConfig().getClassName();
    --- End diff --
   
    As I guessed, this line does not work when action is a spring bean (`getClassName` returns the spring bean id, not fully qualified name of class).
   
    Fortunately it works with actions created by convention plugin.
   
    I will be working on it by checking all references which set or get class name. I also will add some unit tests to check if similar issues occurs in future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r101285251
 
    --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java ---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, CompoundRoot root) {
             Map<String, Object> ctxMap = invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), ctxMap, prepareExcludes(), includes);
    +                String actionConfigClassName = invocation.getProxy().getConfig().getClassName();
    --- End diff --
   
    @lukaszlenart , I study a lot but, while user can equip any custom `ObjectFactory` to create actions (here user has many options like spring aop, javassist, jdk, cglib or any other library), it seems there is no way to determine which properties to set and which should be skipped **except asking from user itself**.
   
    While there are `includes` and `excludes` available for user, but for save user from a lot of typing and also more readability, **what do you think about featuring a new optional parameter named `editableClass` like below?**
    ```xml
    <result type="chain">
        <param name="actionName">myOriginalAction</param>
        <param name="editableClass">me.myname.myactions.MyOriginalAction</param>
    </result>
    ```
    or
    ```xml
    <interceptor-ref name="chainStack">
        <param name="chain.editableClass">me.myname.myactions.MyOriginalAction</param>
    </interceptor-ref>
    ```
    After this featuring, rest of codes of this PR will work and fixes issue in a clean gracefully way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r101292894
 
    --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java ---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, CompoundRoot root) {
             Map<String, Object> ctxMap = invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), ctxMap, prepareExcludes(), includes);
    +                String actionConfigClassName = invocation.getProxy().getConfig().getClassName();
    --- End diff --
   
    What `editableClass` means here? Shouldn't it be a `originClass` or `targetClass`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r101302678
 
    --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java ---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, CompoundRoot root) {
             Map<String, Object> ctxMap = invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), ctxMap, prepareExcludes(), includes);
    +                String actionConfigClassName = invocation.getProxy().getConfig().getClassName();
    --- End diff --
   
    > editable - the class (or interface) to restrict property setting to i.e. only setting properties defined in the given "editable" class (or interface))
    I learnt this name from Spring docs. User also can set a class or interface which is not source class nor target class but an encapsulation of desired properties inside it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r101308839
 
    --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java ---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, CompoundRoot root) {
             Map<String, Object> ctxMap = invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), ctxMap, prepareExcludes(), includes);
    +                String actionConfigClassName = invocation.getProxy().getConfig().getClassName();
    --- End diff --
   
    Hm... ok, let's do it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r101312503
 
    --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java ---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, CompoundRoot root) {
             Map<String, Object> ctxMap = invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), ctxMap, prepareExcludes(), includes);
    +                String actionConfigClassName = invocation.getProxy().getConfig().getClassName();
    --- End diff --
   
    thank you :heart_eyes:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #118: [WW-4105] OgnlUtil improved in order to only setting prop...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on the issue:

    https://github.com/apache/struts/pull/118
 
    😍 PR re-based with last master and ChainingInterceptor equipped with an optional param (editableClass) which user can set to a custom class (or interface) fully qualified name to restrict property setting like below:
    ```xml
    <interceptor-ref name="chainStack">
    <param name="chain.editableClass">me.myname.myactions.MyClassOrInterface</param>
    </interceptor-ref>
    ```
    It is useful when chained actions are unknown proxies created by an unknown object factory and we do not want to copy upper level proxy information which usually breaks their functionality 👌


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #118: [WW-4105] OgnlUtil improved in order to only setting prop...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on the issue:

    https://github.com/apache/struts/pull/118
 
    @lukaszlenart , I am not able to mark this PR with a label `Ready for merge`. I think because I should not have write access to this repository.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #118: [WW-4105] OgnlUtil improved in order to only setting prop...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/118
 
    ech... will ask Infra


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #118: [WW-4105] OgnlUtil improved in order to only setting prop...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/118
 
    only someone with write access can do it, so let's assume that adding :+1: by the author means `Ready for merge` - I will update docs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #118: [WW-4105] OgnlUtil improved in order to only setting prop...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on the issue:

    https://github.com/apache/struts/pull/118
 
    I improved this PR with an interesting Unit Test which prevents similar issues occurrence in future i.e. it checks if `chaining Spring AOPed actions` always works. This Unit Test reproduce the problem and fails in current code which verify the issue [WW-4105] existence.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #118: [WW-4105] OgnlUtil improved in order to only setting prop...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on the issue:

    https://github.com/apache/struts/pull/118
 
    @lukaszlenart , this could be postponed to resolution of [WW-4751](https://issues.apache.org/jira/browse/WW-4751).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #118: [WW-4105] OgnlUtil improved in order to only setting prop...

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/118
 
    Sure, feel free to implement that :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

12
Loading...