Quantcast

[GitHub] struts pull request #117: [WW-4694] annotation processing improved

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #117: [WW-4694] annotation processing improved

lukaszlenart-2
GitHub user yasserzamani opened a pull request:

    https://github.com/apache/struts/pull/117

    [WW-4694] annotation processing improved

    With these changes, [AnnotationUtils](https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/util/AnnotationUtils.java) can navigate around proxies, superclasses and interfaces.
    known issue: for keep it simple, currently it does not support [Bridge Methods](https://docs.oracle.com/javase/tutorial/java/generics/bridgeMethods.html).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yasserzamani/struts WW-4694

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
   
----
commit c84b7967e9eb2f6307466b1644977423831d2ef1
Author: Yasser Zamani <[hidden email]>
Date:   2017-02-05T14:24:28Z

    [WW-4694] annotation processing improved in order to navigate around
    proxies, superclasses and interfaces

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #117: [WW-4694] annotation processing improved

lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/117
 
    I have one general issue: indentation in some files are too big, it should be `4 spaces`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #117: [WW-4694] annotation processing improved

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user yasserzamani commented on the issue:

    https://github.com/apache/struts/pull/117
 
    Thank you. I got it and will fix it by update my eclipse Preferences.
   
    And what about the new codes and comments? some of them are copied from `Spring` framework which itself has `Apache License 2.0` license like Struts2. Do you recommend to rewrite them to something different with same functionality or no, those do not cause any legal issues?
   
    And finally, these changes are needed to fix [WW-4472]. Could you please add this issue id to the title to automatically linking and resolving that issue too?
   
    Thanks in advance!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts issue #117: [WW-4694] annotation processing improved

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/117
 
    Cool, this look great and I don't mind copping code from other libraries if they match license :)
   
    Regarding issue linkage I think you can update the description and put an issue ID there, e.g. `Fixes WW-4472` should be enough


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts pull request #117: [WW-4694] annotation processing improved

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user asfgit closed the pull request at:

    https://github.com/apache/struts/pull/117


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...