Quantcast

[GitHub] struts-extras pull request #1: Changed scope="prototype" to scope="default"

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts-extras pull request #1: Changed scope="prototype" to scope="default"

lukaszlenart-2
GitHub user carstenosu opened a pull request:

    https://github.com/apache/struts-extras/pull/1

    Changed scope="prototype" to scope="default"

    Prototype scope is from Struts 2.5 but doesn't exist in Struts 2.3.x. Default is the equivalent scope in 2.3.x. This resulted in the list of files uploaded being maintained between requests, which will causes issues when two files of the same name are uploaded.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/carstenosu/struts-extras master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts-extras/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
   
----
commit 93517ffcf5fd8d6924f72cbb05c6ff882dd1a1fd
Author: Foley <[hidden email]>
Date:   2017-03-21T23:40:18Z

    Changed scope="prototype" to scope="default" because prototype scope doesn't exist in Struts 2.3.x. Default is the equivalent scope in 2.3.x

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts-extras issue #1: Changed scope="prototype" to scope="default"

lukaszlenart-2
Github user carstenosu commented on the issue:

    https://github.com/apache/struts-extras/pull/1
 
    I realized this is going to break the plugin for everybody running Struts 2.5.x. Perhaps scope="request" would be a better solution since that scope is available to both 2.3 and 2.5.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts-extras issue #1: Changed scope="prototype" to scope="default"

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts-extras/pull/1
 
    `request` exist but it isn't supported, I mean you must implement a dedicated `ScopeStrategy`. The simplest way will be remove bean definition and provide instruction how to setup bean in your `struts.xml`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts-extras issue #1: Changed scope="prototype" to scope="default"

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts-extras/pull/1
 
    Done, I will prepare a release


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts-extras issue #1: Changed scope="prototype" to scope="default"

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user carstenosu commented on the issue:

    https://github.com/apache/struts-extras/pull/1
 
    Works for me, thanks for the quick turnaround!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] struts-extras pull request #1: Changed scope="prototype" to scope="default"

lukaszlenart-2
In reply to this post by lukaszlenart-2
Github user carstenosu closed the pull request at:

    https://github.com/apache/struts-extras/pull/1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...